Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subway stations popup as housenumber-tasks #907

Closed
RubenKelevra opened this issue Feb 23, 2018 · 11 comments
Closed

Subway stations popup as housenumber-tasks #907

RubenKelevra opened this issue Feb 23, 2018 · 11 comments
Labels
feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@RubenKelevra
Copy link
Contributor

I'm currently not entirely sure how to fix this, but it feels wrong that SC create a task to add a house number to a subway station.

Do subway-stations have house numbers?

Example:
https://www.openstreetmap.org/way/378955812

screenshot_20180223-201059

@ENT8R
Copy link
Contributor

ENT8R commented Feb 23, 2018

IMO this is related or even a duplicate of #351...

@RubenKelevra
Copy link
Contributor Author

RubenKelevra commented Feb 23, 2018

Well, this ticket mentions a tag called noaddress=yes, which SC sets if the user selects, that this building has no house number. But this option was obviously removed from SC.

So, maybe it's worth discussing how often buildings with layer=-2 and level=-2 do have house numbers and if it's safe to assume that they do not need to popup as a task?

Currently, we show this task all users and each of them can hide this task once per subway station... this doesn't sound like the right solution here.

EDIT: oh well, I'm tired. Yeah you're right, this might be just another shade of the same grey color and to be fair. But since there are many subway-stations it's still worth a discussion if there's a need for a special filter to block them from this quest. :)

EDIT2: fixed layer & layer error

@ENT8R
Copy link
Contributor

ENT8R commented Feb 23, 2018

But this option was obviously removed from SC.

No. It was never added. But will be added if this issue is resolved...

@westnordost
Copy link
Member

Hmm, it is tagged as "train station". I wouldn't tag a building there at all, just the platform, but one could argue that it is correct correct to tag a building and maybe even correct to tag it as a "train station".

So, perhaps I can exclude buildings with negative layers from the quest? Though, a negative layer does not mean that something is underground.

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Feb 24, 2018
@goldfndr
Copy link
Contributor

goldfndr commented Feb 24, 2018

Reuben typed layer=-2 and layer=-2 but one of those should be level=-2 and negative level(s) could be a better exclusion than negative layer.

@matkoniecz
Copy link
Member

So, perhaps I can exclude buildings with negative layers from the quest? Though, a negative layer does not mean that something is underground.

Yes, object in question is missing location=underground (it it really is underground). negative layer and level tag may appear on objects that are not underground (though while OK it happens really rarely).

@matkoniecz
Copy link
Member

I added location=underground per streetcomplete/streetcomplete-mapstyle#54 (comment)

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Feb 24, 2018
@RubenKelevra
Copy link
Contributor Author

RubenKelevra commented Feb 24, 2018

So maybe we should make a quest from that? "Is this building underground"? If underground-tag is not attached but level-tag is below 0? :)

@ENT8R
Copy link
Contributor

ENT8R commented Feb 24, 2018

And setting location=overground if the building is over ground?

@matkoniecz
Copy link
Member

@RubenKelevra @ENT8R location=surface is not used and was not documented, so it would be impossible to tag anything for "normal" buildings - I added it on Wiki for now.

westnordost added a commit that referenced this issue Feb 24, 2018
- exclude underground buildings from query (#907)
- exclude buildings with an address node within or on the outline, even if this node is outside of the to-be-downloaded bounding box (#885)
- already exclude buildings with an address node on their outline using a more complex overpass query, substantially increasing performance
- add integration tests for all the cases in which buildings should be excluded
@RubenKelevra
Copy link
Contributor Author

@matkoniecz ah okay, I see the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

5 participants