after upload, remove unanswered quests that are no longer applicable (#1131, #746) #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that I missed it :( Though, I looked at it now and I see no problems. But I will update app version that I use and I will try to test it a bit. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You are also invided to review this, @matkoniecz
Test runs through all green. And simple testing seems to work: answer that a building is a house, upload, observe that a building level quest popped up, undo, upload, observe that the building level quest is gone and a building type quest popped up again.
However, during test, one time it did not work, the log says it uploaded 0 changes. But I could not reproduce it afterwards.
But I am still a bit worried that there is a bug in the logic there somewhere.