New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to open location in another app #1396

Merged

westnordost merged 6 commits into streetcomplete:master from ENT8R:geo-intent

May 29, 2019

Contributor

ENT8R commented May 13, 2019

This PR adds to things:

The option (located in the upper right menu) to open the current visible location in another application installed on the phone (e.g. Vespucci, Google Maps, Maps.Me, or any other android application that can handle a Geo URI)
An intent handler for a Geo URI intent by another app (so you can open a specific location in StreetComplete using a Geo URI)

It fixes #190

ENT8R added 2 commits

May 13, 2019 16:50


          Add the option to open the location in another app

fb7ea41


          Merge branch 'master' into geo-intent

dde94ae

westnordost reviewed

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/MainActivity.java Show resolved Hide resolved

westnordost reviewed

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/tangram/MapFragment.java Show resolved Hide resolved

westnordost reviewed

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/MainActivity.java Outdated Show resolved Hide resolved

westnordost reviewed

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/MainActivity.java Show resolved Hide resolved

westnordost reviewed

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/MainActivity.java Outdated Show resolved Hide resolved

westnordost reviewed

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/MainActivity.java Outdated Show resolved Hide resolved

westnordost requested changes

View reviewed changes

Member

westnordost left a comment

Wow, great job @ENT8R ! Thank you for the contribution, the PR is mostly fine, I noted down a few smaller things that could be enhanced

ENT8R added 3 commits

May 14, 2019 17:52


          Show a toast message in case no other map app is installed

e649ca2


          Improve getters and setters of the MapFragment

107defc


          Improve regex handling and add additional checks

149eec7

westnordost reviewed

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/tangram/MapFragment.java Outdated Show resolved Hide resolved

westnordost reviewed

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/MainActivity.java Show resolved Hide resolved


          Added another check for the coordinates and improved some method calls

westnordost approved these changes

View reviewed changes

westnordost merged commit 9661bb5 into streetcomplete:master

Member

westnordost commented May 29, 2019

Merged, thank you!

ENT8R deleted the geo-intent branch

May 29, 2019 13:13

cyclingcat commented Jun 15, 2019

Could it be that the translation for thie new menu item is missing? My Android 5.1 phone shows this item in English:

The cycling cat

Contributor Author

ENT8R commented Jun 15, 2019

The string was translated for the first time one week ago (according to POEditor), so it was not possible for the translation to be added to version 12.1 which was released more than two weeks ago...
BTW: if you see something like that in the future and you wonder whether a string has been translated or not, you might as well also look by yourself into the translation editor: https://poeditor.com/join/project/IE4GC127Ki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet