reduce chance that quest marker disappears as user zooms in #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a bit weird/surprising/confusing behavior and in general is undesirable and has no benefit it wss especially weird in cases where marker of currently solved quest was not visible and blocked by other nearby quest of the same type note that zooming in still may cause quest to disappear in following cases - low importance quest is displayed because nearby important blocked medium importance quest. On zooming in medium medium importance quest may become unlocked and block formerly visible low importance quest - quests have the same iD after % operation
Closed
westnordost
requested changes
Jul 5, 2019
app/src/main/java/de/westnordost/streetcomplete/tangram/QuestsMapFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/tangram/QuestsMapFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/tangram/QuestsMapFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/tangram/QuestsMapFragment.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tobias Zwick <newton@westnordost.de>
matkoniecz
changed the title
westnordost
approved these changes
Jul 6, 2019
matkoniecz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bit weird/surprising/confusing behavior and in general
is undesirable and has no benefit
it wss especially weird in cases where marker of currently solved
quest was not visible and blocked by other nearby quest of the same
type
note that zooming in still may cause quest to disappear in
following cases
blocked medium importance quest. On zooming in medium
medium importance quest may become unlocked and
block formerly visible low importance quest
In this case noone actually complained/noticed during testing except myself.
My work on this pull request and UX testing was sponsored by a NGI Zero Discovery grant