fix missing | #1476
Merged
fix missing | #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The parentheses around all but area=yes look unnecessary, is there a strategy or aesthetic value? |
|
Oh, thanks! |
I admit that I am not sure why it is there, but I worry that changing it will break something subtle (and this is not some code that is often changed, so I prefer to do other refactoring). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also thought about building regexpes from arrays, but for now went with this.
before: mudwater matched, mud nor water not. After change both mud and water matches as intended.
My work on this pull request was sponsored by a NGI Zero Discovery grant