make star icon clickable #1478
make star icon clickable #1478
Conversation
2 out of 7 users during UX tests tried to click it, as their very first action it is also quite obvious place to click this add some minimal info there, in future it may be place to show multiple badges/achievements
|
So what happens when you click on it? |
|
Have you tried running the code or looking at the patch (see "Files changed" tab at top, linked to https://github.com/westnordost/StreetComplete/pull/1478/files )? |
|
Just wanted to say this is a good info in a PR. |
|
- <string name="about_missing_stars">Currently star count is not shared across devices, but answers are added directly to the OpenStreetMap database.</string>
- <string name="how_to_get_stars">Select one of markers on the map and answer the question. This way you will improve OpenStreetMap data and get stars. If you see no markers you may need to zoom out map.</string>
+ <string name="about_missing_stars">Currently, the star count is not shared across devices, but answers are added directly to the OpenStreetMap database.</string>
+ <string name="how_to_get_stars">Choose one of the markers on the map and answer the question. This way you will improve OpenStreetMap data and get stars. If you see no markers you may need to zoom in or out the map.</string>I changed to "zoom in or out" because when one zooms out very far the markers disappear. I changed "Select" to "Choose", as the latter is a more fitting common term in the UI (UX?) when one doesn't have simultaneous multiple choice ability and the element interaction has an immediate consequence. Normally, I prefer a "then" in such a long "if", but dropping it in informal conversation is common. |
Which is not possible for a multi-line diff, or is it? |
|
Anyway, regarding this PR, I am not sure about this. I have other plans for the star button, namely, to lead to the stats and achievements screen later on. So, this feels like an intermediate solution to me, and I generally am hesitant to push intermediate solutions to be translated. On the other hand, if the strings are written in a way that they fit later for maybe the "achievements" (= "did you know"-screens with nice pictures, triggered when reaching certain goals), it would not hurt. |
|
I created a comment, using gitlab syntax, and now realize the syntax is GitLab's not GitHub's. 😊 |
Yes, it was discussed a bit in #178 - I like this plan, this is intended as the first step in this direction.
My plan is to use both
and
in one of rewards/badges in a proper star menu.
is intentionally separate and merged manually into one string as hopefully in the future it will be no longer true (given results of UX testing I will try to work on stars/rewards/synchronization). |
|
Thanks for language review! I applied most of it
I decided to not use this part. For heavy zoom out there either is (or should be) some warning about this situation and warning that quest are hidden. And among new mappers is not something that seems to happen (though my sample size is low) and "zoom in or out" is making this advice really, really unclear. |
app/src/main/res/values/strings.xml
Outdated
| @@ -661,4 +661,7 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards | |||
| <string name="quest_ferry_motor_vehicle_name_title">Does %s transport motor vehicles?</string> | |||
| <string name="quest_ferry_motor_vehicle_title">Does this ferry route transport motor vehicles?</string> | |||
| <string name="create_new_note_hint">Best write the note in the locally spoken language or otherwise in English.</string> | |||
| <string name="about_contributing">Your answers are directly improving OpenStreetMap. Contributed data is open, everyone can use it. Many great projects are already using it.</string> | |||
| <string name="about_missing_stars">Currently star count is not shared across devices, but answers are added directly to the OpenStreetMap database.</string> | |||
There was a problem hiding this comment.
<string name="about_missing_stars">Currently, the star count is not shared across devices, but answers are added directly to the OpenStreetMap database.</string>
<string name="how_to_get_stars">Choose one of the markers on the map and answer the question. This way you will improve OpenStreetMap data and get stars. If you see no markers you may need to zoom in or out the map.</string>
(I have no idea if my adapted syntax is functional.)
|
@westnordost At some point it got removed - is it a regression or an intentional change? |
|
Intentional. The tutorial replaced ths. |
|
I still regularly try to click on the star to get to the profile |
this is adding additional way to achive the same thing, which is typically to be avoided but - Noticeable part of people tries to tap it, especially newbies (see streetcomplete#1478 - also confirmed by susbsequent testing) - similar interface element (score counter in the main menu) is typically clickable and links statistics/leaderboard. Even if such element by itself is not styled as a button. - is unlikely to be confusing to anyone and unlikely to make interface worse - is not requiring ugly code (most of effort is used by writing this commit message) fixes streetcomplete#3698
2 out of 7 users during UX tests tried to click it, as their very first action
it is also quite obvious place to click
this adds some minimal info there, in future it may be place to show multiple badges/achievements
My work on this pull request and UX testing was sponsored by a NGI Zero Discovery grant