Overpass performance

[westnordost]

Fixes #1514

Additionally to the code, the list here needs to be reviewed to find any potential mistakes in the overpass query generation algorithm:

#1514 (comment)

[matkoniecz]

I was looking at #1514 (comment) (I made no attempt to verify code or to check that queries listed there are actually what SC uses).

Is it intentional that _link roads will no longer gave max speed quest? In my experience link roads often have limits, even ones on motorways (it is caused by appearance of ^ $ delimiters).

The same for AddWayLit.

[bbox:{{bbox}}];
node[barrier = height_restrictor] -> .n1;
node[amenity = parking_entrance][parking ~ '^underground|multi-storey$'][!maxheight][!'maxheight:physical'] -> .n2;
(.n1; .n2;);

out meta geom;

seems to be missing [!maxheight][!'maxheight:physical'] part for [barrier = height_restrictor] or it is spurious for [amenity = parking_entrance].

---

I found several things to improve during looking at queries, so I will open some PRs with minor fixes before reviewing code.

[westnordost]

Thank you for the review.

Regarding AddMaxHeight, this is indeed a bug! Phew, good that you found it! I'll have a look!

Regarding AddWayLit and AddMaxSpeed, nothing changed. It was always be like this.

[matkoniecz]

Regarding AddWayLit and AddMaxSpeed, nothing changed. It was always be like this.

In that case I am going to reclassify it as "things to improve found during looking at queries" and open PR for that.

I'll have a look!

And once it is fixed I will merge this PR into version of app that I use on survey, maybe I will spot something additional.

[westnordost]

AddMaxHeight

[bbox:{{bbox}}];
node[barrier = height_restrictor] -> .n2;
node[amenity = parking_entrance][parking ~ '^underground|multi-storey$'] -> .n3;
(.n2; .n3;) -> .n1;
node.n1[!maxheight][!'maxheight:physical'];

out meta geom;

[bbox:{{bbox}}];
way[highway ~ '^motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link|unclassified|residential|living_street|track|road$'] -> .w2;
way[highway = service][access !~ '^private|no$'][vehicle !~ '^private|no$'] -> .w3;
(.w2; .w3;) -> .w1;
way.w1[covered = yes] -> .w4;
way.w1[tunnel ~ '^yes|building_passage|avalanche_protector$'] -> .w5;
(.w4; .w5;) -> .w1;
way.w1[!maxheight][!'maxheight:physical'];

out meta geom;

[matkoniecz]

BTW, it is really great that performance of queries will be so increased! Both for SC users and Overpass servers.

[westnordost]

Hmm, it is still wrong, now for other queries.

[westnordost]

Ok, now it should be fine. (Updated the comment in #1514 with all the filters)