Multiple collection times on the same weekdays as selected before

[kmpoppe]

Closes #2108.

Quest for adding collection times to amenity=post_box nodes was changed.

Just like the quest for adding opening times, this quest will now, if there already is a row, ask if you want to add a collection time to the same weekday(s) as the row before or if you want to add more weekdays.

CollectionTimesAdapter.addNew() was intentionally left in the code (I'm not sure if Android Studio correctly finds all references) bur calls addNewWeekdays(). If this should be removed, please advise @westnordost.

[westnordost]

Looks fine, thank you! I just have a few small comments.

Did you test it?

[kmpoppe]

Looks fine, thank you! I just have a few small comments.

Will change them in the morning, thanks.

Did you test it?

I tested it on my phone from the Dev app that Android studio runs on the phone, yes. The UI works fine, but I don't know how to test if the changes really check out in reality. What's your way of checking if then changes you made create the desired result in the OSM Data?

[westnordost]

I tested it on my phone from the Dev app that Android studio runs on the phone, yes. The UI works fine, but I don't know how to test if the changes really check out in reality. What's your way of checking if then changes you made create the desired result in the OSM Data?

I run the app without being logged in, then I solve a quest and look at the log in Android Studio (filter by "QuestController" to remove the noise), there you can see what will be tagged.

[kmpoppe]

I run the app without being logged in, then I solve a quest and look at the log in Android Studio (filter by "QuestController" to remove the noise), there you can see what will be tagged.

Nice touch, thanks! Next enhancement: display a message box with the changes if app is in debug mode 😬

[westnordost]

Right, good idea, I implemented it. It is in the settings menu -> show quest forms (last entry)

[kmpoppe]

Did you test it?

Looks good to me. Thanks for the great testing method, make sure the other Contributors get to know about it, it'll be very handy!

[kmpoppe]

@westnordost I just realized that you already put
and (!collection_times or collection_times older today -${r * 2} years)
in the tagFilter, without there being a proper resurvey question operation. Do you want to keep it that way for now (leads to a form asking for the collection times without displaying the currently tagged ones)?

[westnordost]

Yes. It makes sense to revisit collection times every few years. To implement that previous collection times are shown was something I deemed to be too much effort for the gain. See #2105

[westnordost]

Looks good, merging!