-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bike parking access and fee quests #2517
Add bike parking access and fee quests #2517
Conversation
So, I just learned that sadly renaming a branch from which a PR is open will close the PR. |
I think if this is added, also #2496 should be added (with a higher priority, so it does show first). I know, there is disagreement whether it should be asked or not, but I think everyone agrees that at leeast for shed/building/lockers it makes sense to ask. Would you include a "add bicycle parking access" quest for only shed/building/lockers as well into this PR? |
app/src/main/java/de/westnordost/streetcomplete/quests/parking_fee/FeeAnswer.kt
Outdated
Show resolved
Hide resolved
Yes, for this objects it definitely makes sense. |
app/src/main/java/de/westnordost/streetcomplete/quests/parking_fee/AddBikeParkingFee.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Zwick <newton@westnordost.de>
👍 |
For "It is open to the public, but there's a yearly fee and a huge waiting list to get one of the spots" cases, should I just mark it "private?" "Public" only means walk-ins welcome, right? |
@michaelblyons If in doubt, better leave a note. In this case, I'd say "private" is the right choice though: https://wiki.openstreetmap.org/wiki/Key:access#List_of_possible_values |
Closes #2496, closes #2507.
As @matkoniecz noted in #2509 (comment), this was much easier to implement than #2509. Also it should be less controversial 😉
However, I had already started coding #2509 when #2507 was opened, so I stuck with it first.
This also includes an icon for #2496, as I created that icon first by mistake, and then didn't want to throw it away 😄
EDIT: Now this PR also includes a full quest for that icon 😉
Screenshot (
AddBikeParkingAccess
)Screenshots (
AddBikeParkingFee
)