Quest presets #3210
Quest presets #3210
Conversation
# Conflicts: # app/src/main/res/raw/changelog.yml # app/src/main/res/values/strings.xml
This reverts commit ecf897d.
…/update_tags/StringMapChangesBuilder.kt Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
Quest profiles - resolve some conflicts, fix upgrade crash
# Conflicts: # app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.kt
There was a problem hiding this comment.
Just a quick (preliminary) code-only review. I don't know if I manage to do a full review, so I just submit this now already.
Thanks for implementing @westnordost! 😊
app/src/main/java/de/westnordost/streetcomplete/data/StreetCompleteSQLiteOpenHelper.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
|
Apparently you can only request reviews from folks who have explicitly been granted access to the repo, but @Helium314 might be interested too |
Co-authored-by: smichel17 <git@smichel.me>
| @@ -1068,4 +1070,14 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards | |||
| <string name="quest_camera_type_dome">Dome</string> | |||
| <string name="quest_camera_type_fixed">Fixed</string> | |||
| <string name="quest_camera_type_panning">Panning</string> | |||
| <string name="no_search_results">The what now?</string> | |||
| <string name="quest_selection_hint_title">Too much to do?</string> | |||
There was a problem hiding this comment.
Although "Too much to do?"
That's pretty much German ("Zu viel zu tun?") literally translated into English. If it doesn't work that well in English, please post a suggestion!
Originally posted by @westnordost in #3210 (comment)
Yeah it works fine in English, I just wonder if there is a bit of a negative connotation about work or it being a job (rather than the gamification side of things). i.e. these are your tasks to complete.
This seems a little softer or just ambiguous (regarding why you're completing the quests) to me:
| <string name="quest_selection_hint_title">Too much to do?</string> | |
| <string name="quest_selection_hint_title">Too many quests?</string> |
Or alternatively to put a more positive spin on it:
| <string name="quest_selection_hint_title">Too much to do?</string> | |
| <string name="quest_selection_hint_title">Too much to choose from?</string> |
There was a problem hiding this comment.
Hmm well, the point is that it should not feel like work and this very dialog addresses that. No point in denying that it may feel like work if there is too much to do. The full dialog reads:
Too much to do?
Contributing should primarily be fun!
If you are overwhelmed by the number of quests, you can always fine-tune which quests are displayed to you and in what order in the settings.
[OK] [Open Settings]
|
Alright, I'll merge this then. If any of you still wanted to review this but didn't find the time to do so yet, you are welcome to add your comments after the merge too. |
fixes #3034, and more. Interface for the quest presets is similar to
Device-2021-07-13-222557-1.1.mp4
although the preset selection is now not a dialog anymore but a full-screen view.
Part of the changelog message:
🚌🚴 Quest presets
This was a much requested feature: (Toggle quest filters #1301, Add quest presets #1654, Groups for Quest selection? #1746, Add a car mode #1987, Ability to create profiles #2054, [WIP] add quest presets #2069, Profiles for quest-types and -order #2279, Quest filters #2565, Organize / sort quests (groups/folders) #2308, Allow to save/load current state of enabled quests #3034, ...)