Simplify shared complex element filters

[FloEdelmann]

Instead of keeping a large chunk of copy-pasted (and then adjusted) code in sync between three quests, create the filtered lists programmatically from one single source of truth.

I noticed this in #3649 because the auto-formatting really messed up the indentation there.

[westnordost]

Uhm, this is kind of a dejavú. I thought I remember rejecting a very similar pull request some time ago. Yes, it is shorter (though just 50 lines), but this is where the advantages end:

1. The filter logic is split up in several files. More difficult to navigate.

2. Not the common filter logic is put into that separate file but all of it. So, after putting all the filter logic in one file, you need to separate it again with this unusual construct

   val common = setOf(AddOpeningHours::class, AddPlaceName::class, AddWheelchairAccessBusiness::class)
   val nameAndOpeningHours = setOf(AddPlaceName::class, AddOpeningHours::class)
   val nameAndWheelchair = setOf(AddPlaceName::class, AddWheelchairAccessBusiness::class)

which leads to the filter logic for each individual quest being scattered all over the place. I am surprised you find this more readable.

[FloEdelmann]

Uhm, this is kind of a dejavú. I thought I remember rejecting a very similar pull request some time ago.

Hmm, I didn't know/remember that, otherwise I wouldn't have opened this PR.

The filter logic is split up in several files.

Yeah, but it kinda is right now, too, because you should check all three files when making a change in any one of them.

---

I'm fine with closing this if it doesn't improve (or actually harms) the readability for others. Do you think there is another way it could be improved?

[westnordost]

Probably not, what would be permissable is to outsource filter logic for certain properties of things. E.g. fun Element.isWalkIn() or similar for places where you can usually just walk in, the same way the isAKindOfShop function exists for things thta usually exist in a Ladenfläche. Though I am really not sure if something like that could be found, because in the end it maybe boils down to usuallyHasOpeningHours, usuallyHasName etc. which would be 1:1 what the quests filter now.

[mnalis]

@FloEdelmann maybe related to this #3302 ?