Resurvey for opening_hours:signed=no (fixes #3130)
#3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
reviewed
Jan 27, 2022
app/src/main/java/de/westnordost/streetcomplete/data/osm/osmquests/OsmElementQuestType.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/barrier_type/AddStileType.kt
Outdated
Show resolved
Hide resolved
...in/java/de/westnordost/streetcomplete/quests/opening_hours_signed/CheckOpeningHoursSigned.kt
Outdated
Show resolved
Hide resolved
…ests/OsmElementQuestType.kt Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
…_hours_signed/CheckOpeningHoursSigned.kt Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
|
Thank you for the review! |
peternewman
reviewed
Jan 27, 2022
Comment on lines
-64
to
-70
| // => properties that refer to the old replaced stile should be removed | ||
| tags.deleteIfExistList(STILE_PROPERTIES - "material") | ||
| if(newMaterial != null) { | ||
| tags["material"] = newMaterial | ||
| } else { | ||
| tags.remove("material") | ||
| } |
There was a problem hiding this comment.
Cool, I was going to say this looked like it could be simplified. 🥳
peternewman
added a commit
to peternewman/StreetComplete
that referenced
this pull request
Jan 27, 2022
peternewman
added a commit
to peternewman/StreetComplete
that referenced
this pull request
Jan 28, 2022
peternewman
reviewed
Jan 28, 2022
app/src/test/java/de/westnordost/streetcomplete/quests/barrier_type/AddStileTypeTest.kt
Show resolved
Hide resolved
peternewman
reviewed
Jan 28, 2022
app/src/main/java/de/westnordost/streetcomplete/data/osm/osmquests/OsmElementQuestType.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask every year whether places that have been tagged with having no opening hours sign (now) have one. This way, implictly, POIs with no (signed) opening hours are checked every year whether they are still there. Also, maybe they have an opening hours sign now. Fixes #3130.
Direct link to the new quest source code: https://github.com/streetcomplete/StreetComplete/compare/opening-hours-signed-resurvey?expand=1#diff-b05845227ebb46097644bc5eab15e1b36ece352cb19d1bc7489cf0f124950c08
Furthermore, typealiased
StringMapChangesBuildertoTags, simply because it is shorter.This PR was mentioned in #3680