Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow lit quest to change to steps on footway #3722

Merged

Conversation

arrival-spring
Copy link
Contributor

At the moment the lit quest can change any highway to steps.

I have no evidence of this producing bad data, but the steps other answer should only be shown on ways that are likely to be steps.

I think that the only highway that the lit quest is shown for that could be changed to steps is footway.

Maybe this code isn't as readable now, it could be changed to more clearly only return the steps answer for footway which isn't an area - should I do that?

@matkoniecz
Copy link
Member

What about highway=path?

@arrival-spring
Copy link
Contributor Author

What about highway=path?

Because highway=path isn't asked in the lit quest.

I think reason why not is because path is thought of as usually more rural, so lit=no is assumed?

(Personally I use path in urban areas where I'm not sure about allowed usage, so would be happy for it to be included in lit quest, but on the other hand it could produce a lot of spam of quest on rural paths which are all not lit.)

@westnordost
Copy link
Member

Good find, thank you!

Your assumption about why lit is not asked for paths is correct.

@westnordost westnordost merged commit 3806f83 into streetcomplete:master Feb 5, 2022
@arrival-spring arrival-spring deleted the lit-steps-footway branch February 6, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants