Only allow lit quest to change to steps on footway #3722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the lit quest can change any highway to steps.
I have no evidence of this producing bad data, but the steps other answer should only be shown on ways that are likely to be steps.
I think that the only highway that the lit quest is shown for that could be changed to steps is
footway
.Maybe this code isn't as readable now, it could be changed to more clearly only return the steps answer for
footway
which isn't an area - should I do that?