always return complete ways on getMapDataWithGeometry

[Helium314]

fixes #4980

MapDataCache can now fetch nodes if for some reason it's neither in SpatialCache nor in nodeCache. This can be because of trim (simply clears nodeCache), but also for other reasons, e.g. SpatialCache removing tiles unexpectedly (see #4985).

Performance:

• getMatDataWithGeometry is slower
  • for large bboxes (usually for overlays) 20-30% of total time is spend on finding / adding nodes needed for complete ways
  • for small bboxes (highlighted elements), this is more, around 30-90%. This may seem much, but even on a S4 mini and a debug APK data is returned within 5-20 ms
• update is typically around 10% slower due to properly handling nodeCache (25% observed, this was by far the worst case)
• fetching nodes happens only after trim and after encountering the tilesRect.asBoundingBox(zoom).enclosingTilesRect(zoom) issue
  • fetched nodes are cached in nodeCache, so even after trim this fetch does not happen often
  • for small bboxes, fetching nodes (if necessary) takes typically 50% of the total time of getMatDataWithGeometry
  • for large bboxes (overlays), it's more like 15-20% (up to 60% observed)

IMO the performance impact is acceptable, and likely any improvements will not be worth the effort.

Some work is still to be done: No new tests are added, and some old tests fail now.

[Helium314]

MapDataCache tests work now, and a test is added whether a node outside the bbox is returned if it's part of a way that also has nodes inside the bbox.

ElementsDaoTest.getAllElementsByBbox still fails, and here some more tests should be added (maybe I'll try tomorrow, but feel free to work on this).

[westnordost]

As you say, needs a few tests for the Dao. Additionally, I found some things that could be done to make it faster (again).

[Helium314]

I think with the latest test this is complete now

[westnordost]

Awesome, thank you!

FYI I released the beta already yesterday to stay true to the announcement in the changelog from v52.1 that the beta will be released on the 3rd but included a note that it is known that the feature dependent on this are not fully functional yet.