Ask for opening width on cycle_barrier=single|diagonal too #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westnordost
reviewed
Aug 20, 2024
app/src/main/java/de/westnordost/streetcomplete/quests/barrier_opening/AddBarrierOpening.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/barrier_opening/AddBarrierOpening.kt
Show resolved
Hide resolved
…_opening/AddBarrierOpening.kt Co-authored-by: Tobias Zwick <newton@westnordost.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @ERYpTION in #5812 (comment),
AddBarrierOpeningquest would benefit from being asked oncycle_barrier=singleandcycle_barrier=diagonaltoo. This PR implements it.It perhaps might also be implemented on
cycle_barrier=tilted, but it might be confusing/require new wording (due to it having different widths at different heights), so it is not proposed here. Other cycle barrier types are much more complex, so are ignored here (see this wiki section)