Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how multiple housenumbers are tagged #939

Merged
merged 4 commits into from
Mar 11, 2018

Conversation

ENT8R
Copy link
Contributor

@ENT8R ENT8R commented Mar 3, 2018

This PR fixes #917

Does anybody have improvements regarding the wording?

@exploide
Copy link
Member

exploide commented Mar 3, 2018

Might be a bit pedantic, but does it matter which kind of hyphen is given? I would assume the hyphen-minus ('-') is needed, since this is the de facto character in programming languages and data representations for that purpose. But the one you wrote in the example is probably an em-dash or something like that?! Just scrolled over the wikipedia articles for hyphen, minus, dash, etc. and the variety is insane :D https://en.wikipedia.org/wiki/Hyphen#Hyphen-minus

The point is: If there are Android keyboards which allow to type - as well as − then users may enter the wrong character. Don't know if such keyboards exist. Surely, it looks better with the one you used.

@westnordost
Copy link
Member

Shorter:
"You can simply input comma-separated housenumbers or as ranges, like i.e. 1,3 or 2-6."

@rugk
Copy link
Contributor

rugk commented Mar 3, 2018

Before the examples I'd add a line break. To not have one block of (though small) text, but to be able to read it faster and just look at the examples.

@ENT8R
Copy link
Contributor Author

ENT8R commented Mar 3, 2018

Should be better now:

What do you think?
Is it OK that the \n is written like that in the string or will that cause problems with the POEditor?

@matkoniecz
Copy link
Member

Would it be better to have either "like" or "i.e." rather than both (I am not 100% sure)?

@ENT8R ENT8R changed the title Explain how multiple housenumber are tagged Explain how multiple housenumbers are tagged Mar 4, 2018
@rugk
Copy link
Contributor

rugk commented Mar 4, 2018

Or even better just write it in the long form and (as that looks much better than splitting a sentence in the middle over two lines) begin a new sentence.

"For instance write…" or so.

Also the grammar is a bit strange there. You "can simply input […] or as ranges". The "as" is strange. Why not just "You can enter […] or ranges".

Maybe use "enter", that is less technical. "Input" is "programmer-speak"… 😉

@rugk
Copy link
Contributor

rugk commented Mar 4, 2018

BTW also funny to see that in @ENT8R's last screenshot the #850 issue happens again in the background.

@westnordost westnordost added this to the v5 milestone Mar 4, 2018
@@ -496,5 +496,5 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards
<string name="quest_fee_not_at_hours">Yes, but not…</string>
<string name="quest_fee_hours_title">at the following times:</string>
<string name="quest_housenumber_multiple_numbers">It has multiple house numbers</string>
<string name="quest_housenumber_multiple_numbers_description">"You can simply input comma-separated house numbers or as ranges,\nlike i.e. 1,3 or 2&#45;6."</string>
<string name="quest_housenumber_multiple_numbers_description">"You can simply enter comma-separated house numbers or ranges.\nFor instance 1,3 or 2-6."</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe nitpick, but why choose comma as separator instead of semi-colon, which ismuch more commun I think in OSM?
https://wiki.openstreetmap.org/wiki/Semi-colon_value_separator

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"," is more common for housenumbers. Search for "," vs ";" on taginfo

@westnordost westnordost merged commit 79ca436 into streetcomplete:master Mar 11, 2018
@ENT8R ENT8R deleted the housenumber-range branch March 11, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explain that tagging list or range of housenumbers is OK
6 participants