Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fail the action if there are errors #1902

Merged
merged 10 commits into from
Aug 12, 2024
Merged

fix: Fail the action if there are errors #1902

merged 10 commits into from
Aug 12, 2024

Conversation

Jason3S
Copy link
Contributor

@Jason3S Jason3S commented Aug 12, 2024

fixes #1897

Note: this is difficult to have a test that guarantees that it will fail, because there is no way to write a workflow to test it 100%.

@coveralls
Copy link

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10354687834

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 93.12%

Changes Missing Coverage Covered Lines Changed/Added Lines %
action-src/src/action.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 10354630121: -0.4%
Covered Lines: 249
Relevant Lines: 259

💛 - Coveralls

@Jason3S Jason3S changed the title fix: Test failed to Import fix: Fail the action if there are errors Aug 12, 2024
@Jason3S Jason3S merged commit d979ffd into main Aug 12, 2024
22 of 23 checks passed
@Jason3S Jason3S deleted the dev-config branch August 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action reports success despite config load error
2 participants