-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add glob support for URLs #5824
Conversation
Performance Report
Note:
|
Add find up to VFS.
The amount of change needed for this feature is impressive |
It was more than I had hoped for. It also includes performance tests and prep work for adding URL support to the gitignore library. The goal:To be able to test globs against URLs as well as file paths. WhyThe spell checker extension in VS Code needs to support spell checking remote files. These come in the form like: ProblemMost JavaScript libraries (like the popular find-up and globby packages) have a hard dependency upon NodeJS.fs to read/write files. Since, Dependency Injection is not yet very common, this has lead me to writing my own libraries. Solution / WorkaroundI ended up creating the following libraries:
|
It is possible to use CSpell in an environment where all the files being spell checked exist behind a virtual URL, something like:
vscode-vfs://github/microsoft/vscode/extensions/csharp/README.md
.The challenge here is to make the glob system URL aware.