Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added spotify dark theme #105

Merged
merged 9 commits into from
Aug 21, 2024
Merged

added spotify dark theme #105

merged 9 commits into from
Aug 21, 2024

Conversation

AOSXAP
Copy link
Contributor

@AOSXAP AOSXAP commented Aug 17, 2024

No description provided.

@echoriiku
Copy link
Collaborator

A dedicated code block theme would be a great addition. The Default Dark code-block CSS theme could serve as a good starting point. Additionally, consider adding a background color to the selected note in the list view. Using the same #212121 as the main section's backdrop might provide a cohesive look.

@AOSXAP
Copy link
Contributor Author

AOSXAP commented Aug 17, 2024

I am not sure how to generate the code-block CSS from the JSON. In the theme builder the CSS field is empty.

@revsuine
Copy link
Collaborator

Add a code-block.css file with your prismjs theme in the same directory as your theme.json

@echoriiku
Copy link
Collaborator

To create your custom code block theme, you can start by copying the Default Dark code block CSS as a base. Make your desired changes to this CSS, then paste the final code into the code block field provided by the theme builder.
Also regarding the theme name "Spotify", let's wait for feedback from @thecodrr before proceeding.

@thecodrr
Copy link
Contributor

thecodrr commented Aug 17, 2024

Yeah the name will need to be changed. Spotify is a trademark and it can create issues for us. I suggest changing it to something different.

Copy link

We found a couple of errors in your submission:

Theme directory must match theme id. Expected theme.json path to be themes/green-glow/v1/theme.json but found themes/greenglow/v1/theme.json.

@AOSXAP
Copy link
Contributor Author

AOSXAP commented Aug 20, 2024

Changed Theme name to green glow and also added code-block.css

@thecodrr
Copy link
Contributor

@echoriiku can you take a look if all is ok? A little busy right now.

@echoriiku
Copy link
Collaborator

echoriiku commented Aug 21, 2024

Changed Theme name to green glow and also added code-block.css

Looks good @AOSXAP, just change the theme description, still "Spotify" there and we're good to go

Copy link

@AOSXAP
Copy link
Contributor Author

AOSXAP commented Aug 21, 2024

@echoriiku done, thanks

@revsuine revsuine merged commit 5c66752 into streetwriters:main Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants