-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added spotify dark theme #105
Conversation
A dedicated code block theme would be a great addition. The Default Dark code-block CSS theme could serve as a good starting point. Additionally, consider adding a background color to the selected note in the list view. Using the same |
I am not sure how to generate the code-block CSS from the JSON. In the theme builder the CSS field is empty. |
Add a |
To create your custom code block theme, you can start by copying the Default Dark code block CSS as a base. Make your desired changes to this CSS, then paste the final code into the code block field provided by the theme builder. |
Yeah the name will need to be changed. Spotify is a trademark and it can create issues for us. I suggest changing it to something different. |
We found a couple of errors in your submission: Theme directory must match theme id. Expected theme.json path to be |
Changed Theme name to green glow and also added code-block.css |
@echoriiku can you take a look if all is ok? A little busy right now. |
Looks good @AOSXAP, just change the theme description, still "Spotify" there and we're good to go |
Your preview URL is: https://theme-builder.notesnook.com/notes?from_pr=streetwriters/notesnook-themes/105 |
@echoriiku done, thanks |
No description provided.