add eink-light theme #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodrr
requested changes
Jan 15, 2024
|
We found a couple of errors in your submission: The JSON file must be named theme.json otherwise it won't work. Theme directory must match theme id. Expected theme.json path to be |
thecodrr
requested changes
Jan 15, 2024
|
@Tsyron thanks for making the changes so quickly. I checked and there's already an almost exact theme called "light-and-dark". |
|
yes, this is true, but text that's slightly grey is hard to read on e-ink |
|
What do you think @Starship-Headlight? Can we make the text black in your |
|
Your preview URL is: https://theme-builder.notesnook.com/notes?from_pr=streetwriters/notesnook-themes/64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an e-ink theme