Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: update Tokyonight theme to Tokyonight Moon and add Tokyonight Day variant #89

Merged
merged 14 commits into from
Jul 30, 2024
Merged

Feat: update Tokyonight theme to Tokyonight Moon and add Tokyonight Day variant #89

merged 14 commits into from
Jul 30, 2024
+289 −372

Conversation

echoriiku
Copy link
Collaborator

@echoriiku echoriiku commented Jul 28, 2024 •
edited
Loading

@aureliuspublius could you please review these changes and let me know if everything looks good? Your feedback would be greatly appreciated.

echoriiku added 4 commits July 27, 2024 20:35
@echoriiku
Feat: update Tokyonight theme to Tokyonight Moon and add Tokyonight D…
ec851fd 
…ay variant

- Updated the Tokyonight theme to the Tokyonight Moon variant
- Added a new variant, Tokyonight Day, following the namescheme of the Tokyonight project
- Included JSON and CSS files for both variants
- Ensured consistency with the original Tokyonight color scheme
@echoriiku
fix authors
7136e73
@echoriiku
typo
bbbaaf9
@echoriiku
update versions
02656aa
@echoriiku
Copy link
Collaborator Author

Is it failing because I changed the theme folder name? It's using the correct namescheme now

thecodrr
thecodrr requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@thecodrr thecodrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the formatting changes?

@echoriiku
Copy link
Collaborator Author

I was annoyed because my changes didn’t work at first. So, I threw the code into a JSON formatter, hoping it would fix some mistake I couldn’t find.

echoriiku
echoriiku commented Jul 29, 2024
View reviewed changes
Copy link
Collaborator Author

@echoriiku echoriiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the unwanted changes, all good

echoriiku
echoriiku commented Jul 29, 2024
View reviewed changes
Copy link
Collaborator Author

@echoriiku echoriiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used the theme builder to correct the unintended formatting changes

thecodrr
thecodrr requested changes Jul 30, 2024
View reviewed changes
themes/tokyonight-moon/v1/code-block.css Outdated Show resolved Hide resolved
themes/tokyonight-day/v1/code-block.css Outdated Show resolved Hide resolved
@thecodrr
Copy link
Contributor

@echoriiku You can't change the id or the directory name for a theme. Since the id is internal, you can leave it be and simply change the title etc. If that doesn't work, you can just create a new theme with the new id.

@streetwriters streetwriters deleted a comment from github-actions bot Jul 30, 2024
@streetwriters streetwriters deleted a comment from github-actions bot Jul 30, 2024
@streetwriters streetwriters deleted a comment from github-actions bot Jul 30, 2024
@streetwriters streetwriters deleted a comment from github-actions bot Jul 30, 2024
@streetwriters streetwriters deleted a comment from github-actions bot Jul 30, 2024
@streetwriters streetwriters deleted a comment from github-actions bot Jul 30, 2024
@streetwriters streetwriters deleted a comment from github-actions bot Jul 30, 2024
@streetwriters streetwriters deleted a comment from github-actions bot Jul 30, 2024
@github-actions GitHub Actions
Copy link

We found a couple of errors in your submission:

themes/tokyonight-dark/v1/theme.json:

You cannot change the ID or directory name of a theme. Since the ID is internal, you can leave it as is and just change the title. Otherwise, please create a new theme with the new id.

themes/tokyonight-light/v1/theme.json:

You cannot change the ID or directory name of a theme. Since the ID is internal, you can leave it as is and just change the title. Otherwise, please create a new theme with the new id.

echoriiku
echoriiku commented Jul 30, 2024
View reviewed changes
Copy link
Collaborator Author

@echoriiku echoriiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted the ID changes

@github-actions GitHub Actions
Copy link

Your preview URL is: https://theme-builder.notesnook.com/notes?from_pr=streetwriters/notesnook-themes/89

@thecodrr thecodrr merged commit 0d27fe7 into streetwriters:main Jul 30, 2024
1 check passed
thecodrr added a commit that referenced this pull request Aug 10, 2024
@echoriiku @thecodrr
themes: revert Tokyonight themes (#101)
83c910c 
* Revert "update Tokyonight theme to Tokyonight Moon and add Tokyonight Day variant (#89)"

This reverts commit 0d27fe7.

* Update themes/tokyonight-dark/v1/theme.json

* Update themes/tokyonight-light/v1/theme.json

---------

Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
thecodrr pushed a commit that referenced this pull request Aug 14, 2024
@echoriiku
themes: add everforest light and dark (#103)
7cd2f0c 
* Revert "update Tokyonight theme to Tokyonight Moon and add Tokyonight Day variant (#89)"

This reverts commit 0d27fe7.

* feat: add everforest light and dark themes

* updated everforest light colors

updated colors for better contrast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecodrr thecodrr thecodrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No contrast between code block and background in Tokyonight Light
2 participants
@echoriiku @thecodrr