Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Themes: Gruvbox, Solarized, and Mystic #93

Closed
wants to merge 23 commits into from
Closed

Add New Themes: Gruvbox, Solarized, and Mystic #93

wants to merge 23 commits into from

Conversation

echoriiku
Copy link
Collaborator

This pull request introduces three new themes — Gruvbox, Solarized, and Mystic — each with both light and dark variants. Your feedback is highly appreciated!

Copy link

github-actions bot commented Aug 1, 2024

@echoriiku echoriiku marked this pull request as ready for review August 1, 2024 13:16
@thecodrr
Copy link
Contributor

thecodrr commented Aug 1, 2024

@echoriiku thanks for this!

All your previous changes are also getting mixed up in this PR. You should delete and recreate your fork then use branches instead of just making changes in the master branch.

This is explained here: https://help.notesnook.com/custom-themes/publish-a-theme

@echoriiku
Copy link
Collaborator Author

Should I delete this PR and make a separate one for each theme after forking it again without the previous changes I made?

@echoriiku echoriiku closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants