web: add readonly branch even in locked notes #5731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoonjae Choi <dbswo9795@gmail.com>
thecodrr
requested changes
May 30, 2024
| @@ -782,6 +782,7 @@ type UnlockNoteViewProps = { session: LockedEditorSession }; | |||
| function UnlockNoteView(props: UnlockNoteViewProps) { | |||
| const { session } = props; | |||
| const root = useRef<HTMLDivElement>(null); | |||
| const isReadOnly = session.note.readonly; | |||
There was a problem hiding this comment.
No need for this constant here. We are only using it in one place so just inline it.
There was a problem hiding this comment.
@thecodrr thank you! I modified it.
Signed-off-by: Yoonjae Choi <dbswo9795@email.com>
thecodrr
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the "readonly" and "locked" states were being branched by the type of session object. Therefore, we were not able to check the read only when the type was "locked". So, we modified the read only to be branched according to the value of session.note.read only when it is locked.