Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cc test reporter #107

Merged
merged 1 commit into from
Jul 7, 2021
Merged

fix cc test reporter #107

merged 1 commit into from
Jul 7, 2021

Conversation

geseq
Copy link
Collaborator

@geseq geseq commented Jul 3, 2021

fixes the cc-test-reporter failure in GitHub workflow

Summary

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Tests are passing: task test
  • Code style is correct: task lint

@geseq
Copy link
Collaborator Author

geseq commented Jul 3, 2021 •
edited
Loading

@hanzei We'll need this to fix the CI failures (on master)

@geseq
Copy link
Collaborator Author

geseq commented Jul 3, 2021

not entirely sure why travis is still being included as a check. Has it been added specifically to branch protection settings maybe?

@geseq geseq mentioned this pull request Jul 3, 2021
Merged
2 tasks
@hanzei hanzei self-requested a review July 5, 2021 15:24
@hanzei
Copy link
Collaborator

hanzei commented Jul 7, 2021

Disabled the travis check

@hanzei hanzei merged commit 31052d3 into stretchr:master Jul 7, 2021
@geseq geseq deleted the fix-workflow branch July 7, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geseq @hanzei