Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported go versions to latest three #149

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Update supported go versions to latest three #149

merged 1 commit into from
Feb 29, 2024

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Feb 29, 2024 •
edited
Loading

Summary

Only support the latest three major go versions

Checklist

  • Tests are passing: task test
  • Code style is correct: task lint

@hanzei hanzei added this to the v0.5.2 milestone Feb 29, 2024
@hanzei hanzei marked this pull request as ready for review February 29, 2024 09:52
@hanzei hanzei merged commit 762bf42 into master Feb 29, 2024
3 checks passed
@hanzei hanzei deleted the update-go branch February 29, 2024 09:55
@dolmen
Copy link
Contributor

dolmen commented Mar 4, 2024 •
edited
Loading

This upgrade wasn't necessary. It will block projects still using an older version of Go from upgrading objx and testify while our code would still work with those old Go versions.

@dolmen dolmen mentioned this pull request Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hanzei @dolmen