Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil value returns empty string. #76

Merged
merged 1 commit into from
May 31, 2018
Merged

Nil value returns empty string. #76

merged 1 commit into from
May 31, 2018

Conversation

geseq
Copy link
Collaborator

@geseq geseq commented May 31, 2018

Added IfNil() check to Value.String()

@hanzei hanzei self-requested a review May 31, 2018 14:23
@hanzei hanzei self-assigned this May 31, 2018
@hanzei hanzei added this to the v0.2 milestone May 31, 2018
hanzei
hanzei approved these changes May 31, 2018
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hanzei hanzei merged commit 77d0150 into stretchr:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

Assignees

@hanzei hanzei

Labels
4. to release
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@geseq @hanzei