Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #7 #85

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Fix for #7 #85

merged 1 commit into from
Feb 4, 2019

Conversation

geseq
Copy link
Collaborator

@geseq geseq commented Feb 1, 2019

Fixes #7

ObjxMapSlice() and MSISlice() casting was already fixed in my previous pull requests. However, the checks in IsObjxMapSlice() and IsMSISlice() weren't.

Fixed and added new tests.

@hanzei hanzei self-assigned this Feb 4, 2019
@hanzei hanzei self-requested a review February 4, 2019 13:55
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hanzei hanzei added this to the v0.2 milestone Feb 4, 2019
@hanzei hanzei merged commit d3a9fb1 into stretchr:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsMSISlice() doesn't work properly
2 participants