Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for map[interface{}]interface{} to JSON conversion #87

Merged
merged 4 commits into from
Feb 11, 2019

Conversation

geseq
Copy link
Collaborator

@geseq geseq commented Feb 6, 2019

If map[interface{}]interface{} end up within the Map, JSON() and MustJSON() fail even if the data is valid. Added methods to cleanup the data before converting to JSON.

@geseq
Copy link
Collaborator Author

geseq commented Feb 6, 2019

@hanzei Do you know what's causing the build to fail?

@hanzei
Copy link
Collaborator

hanzei commented Feb 6, 2019

Your code isn't properly formatted. You can locally check this via task lint.

@geseq
Copy link
Collaborator Author

geseq commented Feb 6, 2019

Right. Fixed.

@hanzei hanzei self-assigned this Feb 6, 2019
@hanzei hanzei self-requested a review February 6, 2019 16:04
@hanzei hanzei added this to the v0.2 milestone Feb 6, 2019
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei hanzei merged commit c61a9df into stretchr:master Feb 11, 2019
@geseq geseq deleted the map-interface-interface branch July 7, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants