Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fix the assert.Subset (and assert.NotSubset) functions for maps
Changes
Updated the
NotSubset(…)
function to check the key's existence in the containing map. Before the fix, if the key did not exist in the containing map, a panic would occur and the function would return false.Updated the
Subset(…)
function to do the same and avoid a panic. This panic was well intercepted and the test returned the correct result, but I figured that this was a better way.Motivation
I noticed that the NotSubset function would not work properly for intersecting maps.
For example, I wanted to check that
{ "a": "x", "d": "z"}
is indeed not a subset of{ "a": "x", "b": "y", "c": "z"}
Related issues
#1173