suite: recover and fail on subtest #1455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please spare the time of the maintainers by filling the description properly. If contributing in English is an issue, please at least tell that. Also:
|
dolmen
changed the title
dolmen
requested changes
Aug 11, 2023
| @@ -108,6 +108,7 @@ func (suite *Suite) Run(name string, subtest func()) bool { | |||
| }() | |||
|
|
|||
| return oldT.Run(name, func(t *testing.T) { | |||
| defer recoverAndFailOnPanic(t) | |||
There was a problem hiding this comment.
This change needs a matching test case for future regression testing.
|
Closing because this change is included in #1471. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Motivation
Related issues