assert: Fix EqualValues to handle overflow/underflow #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunmahishi
force-pushed
the
fix-equal-values
branch
from
36ab024
to
2d27e0f
Compare
MovieStoreGuy
previously approved these changes
Feb 12, 2024
arjunmahishi
added
bug
pkg-assert
brackendawson
requested changes
Feb 14, 2024
The underlying function ObjectsAreEqualValues did not handle
overflow/underflow of values while converting one type to another
for comparison. For example:
EqualValues(t, int(270), int8(14))
would return true, even though the values are not equal. Because, when
you convert int(270) to int8, it overflows and becomes 14 (270 % 256 = 14)
This commit fixes that by making sure that the conversion always happens
from the smaller type to the larger type, and then comparing the values.
Additionally, this commit also seperates out the test cases of
ObjectsAreEqualValues from TestObjectsAreEqual.
Fixes stretchr#1462
arjunmahishi
force-pushed
the
fix-equal-values
branch
from
2d27e0f
to
4c4d011
Compare
brackendawson
approved these changes
Feb 14, 2024
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The underlying function
ObjectsAreEqualValuesdid not handle overflow/underflow of values while converting one type to another for comparison. For example:would return
true, even though the values are not equal. Because, when you convertint(270)toint8, it overflows and becomes 14(270 % 256 = 14)Changes
This commit fixes that by making sure that the conversion always happens from the smaller type to the larger type, and then comparing the values. Additionally, this commit also separates out the test cases of
ObjectsAreEqualValuesfromTestObjectsAreEqual.Related issues
Closes #1462