Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests run by definition order #258

Closed
wants to merge 1 commit into from
Closed

tests run by definition order #258

wants to merge 1 commit into from

Conversation

leebenson
Copy link

@ernesto-jimenez
Copy link
Member

Thanks @leebenson,

I'm afraid I'm still unconvinced about the functionality. We can follow the discussion in the issue #194 and we can reopen the PR if and when we agree this should be implemented and this solution is relying on specified behaviour from Go.

@leebenson
Copy link
Author

@ernesto-jimenez what's the downside?

Alphabetical is an arbitrary order by default. It assumes a 1:1 correlation between name and run order.

If your argument is that definition order shouldn't be linked to run order, then that's equally arbitrary and therefore ordering by method definition makes no material difference to users that don't rely on a particular sequence order.

It's exactly the same thing either way - except my way, you're now satisfying users like myself, the two other guys that opened the issue in #194, and no doubt hundreds of others who DO care about order.

Again - what's the downside?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of test runs in suite
2 participants