Recover panic in suite #696
Conversation
|
@ernesto-jimenez @matryer can you please take a look ? |
|
@georgelesica-wf , can you please take a look ? |
|
Since this is a pretty significant change I'm going to get a few people to look at it and discuss, but I'll keep you posted. |
|
+1 To the general plan. This is roughly the behavior of go tests already (panics are caught by the test framework and reported as a failure) so i think it makes sense for a custom test sit suite to provide the same feature. Also, being able to execute cleanup steps even if there isa panic makes sense. However it appears there is CI failures so let's get those cleaned up before final approval :) |
|
@benechols-wf CI fails only on "Go tip" which is not related to my changes. As you can see, all pull requests(even only with docs 😄 ) are failing on "Go tip". |
|
I created an issue to resolve the CI failures: #705 We'll need to do that before the next release, but I'm fine merging PRs that don't break on released Go versions for now. |
|
@georgelesica-wf any ideas when this can be merged? |
|
Sorry, I've been pretty busy. I'll merge it now, thank you for your patience! Sorry it took awhile. |
Synopsis
PR implements feature suggested in #695 (don't panic in tests, but gracefully recover, mark test as failed and run other tests)