-
-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to run Stride.Core.Tasks program on any desktop OS #2042
Conversation
Those changes have the runtime version explicitly defined instead of being defined through a build variable, I would rather we keep the variable or find another way to fix this issue. |
Looks like part of #1995 was lost when merging the .NET 8 branch. Introducing a new build property should be the way to go. |
|
e4bb6df
to
551ff19
Compare
551ff19
to
312d7d2
Compare
I updated the PR with the newly introduced variable. It also seems to work fine on Fedora 39 😊 |
Is it working on Mac? |
@Jklawreszuk Can you add two more changes? In - <TargetFramework>$(StrideEditorTargetFramework)</TargetFramework>
+ <TargetFramework>$(StrideXplatEditorTargetFramework)</TargetFramework> And update the command line in - <Exec Command=""$(MSBuildThisFileDirectory)..\core\Stride.Core.Tasks\bin\$(Configuration)\$(StrideEditorTargetFramework)\Stride.Core.Tasks$(ExecutableExtension)" pack-assets "$(MSBuildProjectFile)" "$(IntermediateOutputPath)\stride"" ConsoleToMsBuild="true">
+ <Exec Command=""$(MSBuildThisFileDirectory)..\core\Stride.Core.Tasks\bin\$(Configuration)\$(StrideXplatEditorTargetFramework)\Stride.Core.Tasks$(ExecutableExtension)" pack-assets "$(MSBuildProjectFile)" "$(IntermediateOutputPath)\stride"" ConsoleToMsBuild="true"> Without those changes, I wasn't able to build |
done! |
PR Details
Description
This change should enable to build more projects outside Windows platform, like i.e Stride.Graphics.
Related Issue
Types of changes
Checklist