Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to run Stride.Core.Tasks program on any desktop OS #2042

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

Jklawreszuk
Copy link
Collaborator

@Jklawreszuk Jklawreszuk commented Nov 16, 2023

PR Details

Description

This change should enable to build more projects outside Windows platform, like i.e Stride.Graphics.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out

@Eideren
Copy link
Collaborator

Eideren commented Nov 16, 2023

Those changes have the runtime version explicitly defined instead of being defined through a build variable, I would rather we keep the variable or find another way to fix this issue.

@Kryptos-FR
Copy link
Member

Looks like part of #1995 was lost when merging the .NET 8 branch. Introducing a new build property should be the way to go.

@Jklawreszuk
Copy link
Collaborator Author

Jklawreszuk commented Nov 17, 2023

Sure its better to not hardcoding tf, I found StrideFramework property in Stride.Core.props maybe this should be useful?

@Jklawreszuk Jklawreszuk force-pushed the stride.core.tasks branch 2 times, most recently from e4bb6df to 551ff19 Compare January 18, 2024 12:54
@Jklawreszuk
Copy link
Collaborator Author

I updated the PR with the newly introduced variable. It also seems to work fine on Fedora 39 😊

@Kryptos-FR
Copy link
Member

Is it working on Mac?

@Kryptos-FR
Copy link
Member

Kryptos-FR commented Jan 18, 2024

@Jklawreszuk Can you add two more changes?

In Stride.Core.Tasks/Stride.Core.Tasks.csproj, change the target framework:

-    <TargetFramework>$(StrideEditorTargetFramework)</TargetFramework>
+    <TargetFramework>$(StrideXplatEditorTargetFramework)</TargetFramework>

And update the command line in Stride.props:

-    <Exec Command="&quot;$(MSBuildThisFileDirectory)..\core\Stride.Core.Tasks\bin\$(Configuration)\$(StrideEditorTargetFramework)\Stride.Core.Tasks$(ExecutableExtension)&quot; pack-assets &quot;$(MSBuildProjectFile)&quot; &quot;$(IntermediateOutputPath)\stride&quot;" ConsoleToMsBuild="true">
+    <Exec Command="&quot;$(MSBuildThisFileDirectory)..\core\Stride.Core.Tasks\bin\$(Configuration)\$(StrideXplatEditorTargetFramework)\Stride.Core.Tasks$(ExecutableExtension)&quot; pack-assets &quot;$(MSBuildProjectFile)&quot; &quot;$(IntermediateOutputPath)\stride&quot;" ConsoleToMsBuild="true">

Without those changes, I wasn't able to build Stride.Graphics on Ubuntu.

@Jklawreszuk
Copy link
Collaborator Author

done!

@Kryptos-FR Kryptos-FR merged commit ddc7423 into stride3d:master Jan 19, 2024
2 checks passed
@Jklawreszuk Jklawreszuk deleted the stride.core.tasks branch January 19, 2024 10:49
Jklawreszuk added a commit to Jklawreszuk/stride that referenced this pull request Dec 24, 2024
)

* Enable to run Stride.Core.Tasks program on any OS

* Prevent from running "locate-devenv" opt on non-win platforms

* fix invalid OptionException arg

* Apply xplateditor variable to stride.core.tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants