Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update guillotine packer documentation link #2339

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

tymokvo
Copy link
Contributor

@tymokvo tymokvo commented Jun 20, 2024

PR Details

  • Replace link in GuillotinePacker documentation

Description

While browsing the Core.Mathematics namespace, I noticed that the link to http://clb.demon.fi/files/RectangleBinPack.pdf seems to have rotted. After a bit of googling, I think I was able to find the author's github and a link to the PDF there.

Related Issue

None, just a documentation change.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit 60d53fa into stride3d:master Jun 27, 2024
2 checks passed
@Eideren Eideren changed the title Update guillotine packer documentation link docs: Update guillotine packer documentation link Jun 27, 2024
@Eideren Eideren added the area-Math Issues related to the Stride.Core.Mathematics namespace label Jun 27, 2024
@Eideren
Copy link
Collaborator

Eideren commented Jun 27, 2024

Thanks !

@tymokvo tymokvo deleted the fix-guillotine-url branch June 27, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Math Issues related to the Stride.Core.Mathematics namespace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants