Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ChannelMicroThreadAwaiter pooling bug #2373

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

timcassell
Copy link
Contributor

PR Details

When >= 4096 awaiters are pooled, more awaiters are also added to the pool without being reset. This has the effect of possibly causing some await Script.NextFrame() points to continue immediately. This PR fixes that issue.

Related Issue

n/a

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit c5bc5a2 into stride3d:master Jul 6, 2024
3 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jul 6, 2024

Thanks !

@Eideren Eideren added the area-Core Issue of the engine unrelated to other defined areas label Jul 6, 2024
@timcassell timcassell deleted the fix-microthreadawaiter-pool branch July 7, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Core Issue of the engine unrelated to other defined areas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants