Update the Prometheus JMX Collector and Client #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
ppatierno
approved these changes
Jun 4, 2024
antonio-pedro99
pushed a commit
to antonio-pedro99/strimzi-kafka-bridge
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Antonio Pedro <tonio.pedro99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Prometheus JMX Collector to 1.0.1. This new version has many changes to how it treats the metrics with some keywords such as
_total. This required an update to the metrics configuration YAMl to maintain the compatibility of the produced metrics (essentially, the counters using_totalsuffix need to be mapped to counters in the rules).In addition, the Prometheus Simple Client is now archived and not anymore supported by the Prometheus JMX Exporter. So it also moves the bridge to use the current Prometheus Client.