Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of additional volumes in pod #10099
Support of additional volumes in pod #10099
Changes from 12 commits
da3af5c
a97329e
d3fd12b
0ca3cc2
32f0777
e5782d0
09bc97b
5523212
a506979
51a162c
9dfacaf
bdfc674
d7a6944
4a367f3
f375c3c
bcc20b8
124d904
c511396
7d75c9c
1703c3e
775e028
ba3c1ea
1b36089
5544391
a13d01a
2049a29
6815a00
ea2044c
0205e92
7588fb4
c675025
1ee00a4
e42e795
8085b20
ae3de84
6438087
059f143
7f3daa2
edf5624
17ee14e
83c1825
b8a8a47
187cc66
1ccc7c2
663c943
0496cc2
a5d30e9
a954dcb
011f6f1
7eb8447
d80f6c0
ccc4171
d5ff6e9
1a58829
d8aefb2
ad46503
d7e808b
fea2cef
e1b6a93
a3cd0c8
45ed5e1
84aa5f7
89933ee
e009277
ca9eb61
3640dbe
9e0915c
20199b7
c5bb07a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why is the field here called
additionalVolumeMounts
? Why not just call itvolumeMounts
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have renamed the variable to
volumeMounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why the field is called
additionalVolumes
and not justvolumes
? I get that calling the classAdditionalVolume
helps to avoid class name conflicts. So that is good and useful. But the field can be simply called justvolumes
here, or?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelMorrisEst What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have renamed the variable to
volumes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annotation is not needed anymore I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed?
@JsonProperty("volumes")