Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(resources): clarifies where resources (requests and limits) are configured #10299

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Jul 3, 2024

Documentation

Updates the common configuration section on resource requests and limits to describe in which customer resources to configure resources.

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

…configured

Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor PaulRMellor added this to the 0.42.0 milestone Jul 3, 2024
@PaulRMellor PaulRMellor requested a review from a team July 3, 2024 15:05
@PaulRMellor PaulRMellor self-assigned this Jul 3, 2024
@scholzj scholzj modified the milestones: 0.42.0, 0.43.0 Jul 3, 2024
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (apart Jakub's suggestion)

Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor
Copy link
Contributor Author

@scholzj thanks for the review
I've addressed the comment

@scholzj scholzj merged commit f82cf3d into strimzi:main Jul 4, 2024
13 checks passed
mstruk pushed a commit to mstruk/strimzi-kafka-operator that referenced this pull request Jul 15, 2024
…configured (strimzi#10299)

Signed-off-by: prmellor <pmellor@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC]: Clarify where the resources for the pods should be configured
3 participants