Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system test] bandwidth quota test and performance measurement #10321

Merged
merged 4 commits into from
Jul 12, 2024
Merged

[system test] bandwidth quota test and performance measurement #10321

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb9a668
[system test] bandwidth quota test and performance measurement
see-quick Jul 10, 2024
9ec93a3
do not limit to minikube or such infra
see-quick Jul 10, 2024
8d8354c
add such test to regression
see-quick Jul 10, 2024
4429efd
use default config
see-quick Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions systemtest/src/test/java/io/strimzi/systemtest/kafka/QuotasST.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.hamcrest.CoreMatchers;
import org.hamcrest.Matchers;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Tag;
Expand All @@ -33,6 +34,7 @@

import static io.strimzi.systemtest.TestConstants.INTERNAL_CLIENTS_USED;
import static io.strimzi.systemtest.TestConstants.QUOTAS_PLUGIN;
import static io.strimzi.systemtest.TestConstants.REGRESSION;
import static io.strimzi.test.k8s.KubeClusterResource.kubeClient;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assumptions.assumeFalse;
Expand Down Expand Up @@ -128,6 +130,83 @@ void testKafkaQuotasPluginIntegration() {
ClientUtils.waitForInstantProducerClientSuccess(testStorage);
}

@ParallelNamespaceTest
@Tag(INTERNAL_CLIENTS_USED)
@Tag(REGRESSION)
void testKafkaQuotasPluginWithBandwidthLimitation() {
final TestStorage testStorage = new TestStorage(ResourceManager.getTestContext());
final String excludedPrincipal = "User:" + testStorage.getUsername();

resourceManager.createResourceWithWait(
NodePoolsConverter.convertNodePoolsIfNeeded(
KafkaNodePoolTemplates.brokerPoolPersistentStorage(testStorage.getNamespaceName(), testStorage.getBrokerPoolName(), testStorage.getClusterName(), 1).build(),
KafkaNodePoolTemplates.controllerPoolPersistentStorage(testStorage.getNamespaceName(), testStorage.getControllerPoolName(), testStorage.getClusterName(), 1).build()
)
);
resourceManager.createResourceWithWait(
KafkaTemplates.kafkaPersistent(testStorage.getClusterName(), 1, 1)
.editSpec()
.editKafka()
.addToConfig("client.quota.callback.static.storage.check-interval", "5")
.withNewQuotasPluginStrimziQuotas()
.addToExcludedPrincipals(excludedPrincipal)
.withProducerByteRate(1000L) // 1 kB/s
.withConsumerByteRate(1000L) // 1 kB/s
.endQuotasPluginStrimziQuotas()
.withListeners(
new GenericKafkaListenerBuilder()
.withName(TestConstants.PLAIN_LISTENER_DEFAULT_NAME)
.withPort(9092)
.withType(KafkaListenerType.INTERNAL)
.withTls(false)
.build(),
new GenericKafkaListenerBuilder()
.withName("scramsha")
.withPort(9095)
.withType(KafkaListenerType.INTERNAL)
.withTls(false)
.withNewKafkaListenerAuthenticationScramSha512Auth()
.endKafkaListenerAuthenticationScramSha512Auth()
.build()
)
.endKafka()
.endSpec()
.build()
);
resourceManager.createResourceWithWait(
KafkaTopicTemplates.topic(testStorage.getClusterName(), testStorage.getTopicName(), testStorage.getNamespaceName()).build(),
KafkaUserTemplates.scramShaUser(testStorage).build()
);

KafkaClients clients = ClientUtils.getInstantPlainClientBuilder(testStorage, KafkaResources.plainBootstrapAddress(testStorage.getClusterName()))
.withMessageCount(100)
.withMessage(String.join("", Collections.nCopies(2000, "#")))
.withAdditionalConfig("delivery.timeout.ms=10000\nrequest.timeout.ms=10000\n")
see-quick marked this conversation as resolved.
Show resolved Hide resolved
.build();

LOGGER.info("Sending messages with normal user, quota applies");
long startTimeNormal = System.currentTimeMillis();
resourceManager.createResourceWithWait(clients.producerStrimzi());
ClientUtils.waitForInstantProducerClientSuccess(testStorage);
long endTimeNormal = System.currentTimeMillis();
long durationNormal = endTimeNormal - startTimeNormal;
LOGGER.info("Time taken for normal user: {} ms", durationNormal);

// Measure time for excluded user
LOGGER.info("Sending messages with excluded user, no quota applies");
clients = ClientUtils.getInstantScramShaClientBuilder(testStorage, KafkaResources.bootstrapServiceName(testStorage.getClusterName()) + ":9095").build();

long startTimeExcluded = System.currentTimeMillis();
resourceManager.createResourceWithWait(clients.producerScramShaPlainStrimzi());
ClientUtils.waitForInstantProducerClientSuccess(testStorage);
long endTimeExcluded = System.currentTimeMillis();
long durationExcluded = endTimeExcluded - startTimeExcluded;
LOGGER.info("Time taken for excluded user: {} ms", durationExcluded);

// Assert that time taken with normal user is greater than with excluded user
assertThat("Time taken for normal user should be greater than time taken for excluded user", durationNormal, Matchers.greaterThan(durationExcluded));
}

@AfterEach
void afterEach() {
final String namespaceName = StUtils.getNamespaceBasedOnRbac(Environment.TEST_SUITE_NAMESPACE, ResourceManager.getTestContext());
Expand Down
Loading