Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(partition tool): clarifies the process to change preferred leader #10324

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Jul 10, 2024

Documentation

Clarifies the process for changing the preferred leader when using the partition reassignment tool.
It makes it clear that the order of replicas is important.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.43.0 milestone Jul 10, 2024
@PaulRMellor PaulRMellor self-assigned this Jul 10, 2024
Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor
Copy link
Contributor Author

Thanks for the feedback @fvaleri. Do we need to mention unclean leader election in the section? Not sure of its relevance to this.

@fvaleri
Copy link
Contributor

fvaleri commented Jul 15, 2024

Do we need to mention unclean leader election in the section? Not sure of its relevance to this.

No, the right context would be where we talk about offline partitions.

Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor
Copy link
Contributor Author

Thanks for additional comments @fvaleri

Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@PaulRMellor
Copy link
Contributor Author

@strimzi/maintainers - Looking for sign off

Copy link
Member

@Frawless Frawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not SME, but LGTM

@scholzj
Copy link
Member

scholzj commented Jul 18, 2024

@PaulRMellor You can request review from the maintainers group when you need one.

@scholzj scholzj merged commit f9e76bd into strimzi:main Jul 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants