Fixed ZooKeeper service usage to delete /controller znode on migration rollback #10373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollback Signed-off-by: Paolo Patierno <ppatierno@live.com>
scholzj
reviewed
Jul 23, 2024
...perator/src/main/java/io/strimzi/operator/cluster/operator/assembly/ZooKeeperReconciler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
/azp run migration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
approved these changes
Jul 23, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR fixes #10371.
The current code, to get the ZooKeeper connection string from the service in order to connect to ZooKeeper and delete the
/controllerznode during KRaft migration rollback, doesn't take into account the full name (i.e. including namespace), so the operator can't connect when the cluster is running in a different namespace.The PR fixes it.
Checklist