Udpate some unit and integration tests to use KRaft #10394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
im-konge
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
We have still a large amount of tests that use ZooKeeper-based Kafka clusters. For some tests, the ZooKeeper part is completely irrelevant and we should just update the tests to not use any fields that are part of ZooKeeper-based clusters in order to not have to deal later with deprecations etc. For other tests, large changes are needed. In some cases, it makes sense to keep the original ZooKeeper-based tests for as long as we support ZooKeeper.
In this PR (that updates just few tests out of many - others will follow in further PRs):
JbodStorageMockTestis rewritten to use KRaft and Node Pools. The old test is kept asJbodStorageMockZooBasedTest. It will be deleted when ZooKeeepr-support is removed, but until then it seemed useful to keep it and make sure this works.This PR also adds a new method for generating pod names when node pools are used to
KafkaResources. The old method works only for clusters not using node pools. So having an alternative method for use with node pools seemed useful for users but also for our own tests.Checklist