Fix flaky CustomCaST.testReplacingCustomClusterKeyPairToInvokeRenewalProcess system test
#10414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Process system test Signed-off-by: Jakub Scholz <www@scholzj.com>
Frawless
approved these changes
Aug 2, 2024
im-konge
approved these changes
Aug 2, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Aug 3, 2024
scholzj
deleted the
fix-race-condition-in-CustomCaST-testReplacingCustomClusterKeyPairToInvokeRenewalProcess
branch
|
/azp run regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The
CustomCaST.testReplacingCustomClusterKeyPairToInvokeRenewalProcessseems to be very flaky in KRaft mode. This is because the annotation for the manual rolling update of the broker StrimziPodSet resources is done right after the manual rolling update of the controllers and that makes it very likely to be overwritten right away when the broker pod set is patched.This PR tries to set both annotations right at the beginning to avoid this race condition. This should also speed up the test as it will not need to wait for another reconciliation.
Checklist