Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next wave of KRaft based unit tests #10422

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 5, 2024

Type of change

  • Task

Description

This PR includes another set of unit tests updated for KRaft:

  • KafkaStatusTest and KRaftVersionChangeCreatorTest do not use ZooKeeper and have basically just updated Kafka resources where the (used-to-be mandatory) sections related to ZooKeeper are removed.
  • The original PartialRollingUpdateMockTest is kept untouched as PartialRollingUpdateZooBasedMockTest without any changes. This test will be deleted when Zoo support is removed. A rewritten PartialRollingUpdateMockTest contains the KRaft based tests.

Checklist

  • Write tests
  • Make sure all tests pass

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.43.0 milestone Aug 5, 2024
@scholzj scholzj requested a review from ppatierno August 5, 2024 23:38
Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit 5ed14ee into strimzi:main Aug 7, 2024
13 checks passed
@scholzj scholzj deleted the add-more-KRaft-based-unit-tests branch August 7, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants