Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more KRaft-based unit tests #10424

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 6, 2024

Type of change

  • Task

Description

Another set of unit tests updated for KRaft:

  • KubernetesRestartEventsMockTest is not related to ZooKeeper in any way. So it was just updated to use KRaft.
  • KafkaReconcilerStatusTest was also mostly unrelated to ZooKeeper. So it was rewritten as well. The tests that seemed to make sense keeping separate with ZooKeeper were added to KafkaReconcilerStatusZooBasedTest.

Checklist

  • Write tests
  • Make sure all tests pass

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.43.0 milestone Aug 6, 2024
@scholzj scholzj requested a review from ppatierno August 6, 2024 16:24
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit 4f7f5a4 into strimzi:main Aug 7, 2024
13 checks passed
@scholzj scholzj deleted the even-more-kraft-based-unit-tests branch August 7, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants