Update of unit tests to use KRaft - part 5 #10431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This is the fifth PR with unit test updates to use KRaft. This time, it does the following changes:
KafkaListenerReconcilerClusterIPTestandKafkaListenerReconcilerSkipBootstrapLoadBalancerTestwe updated to use KRaft since they are independent on ZooKeeper. I also merged both classes into a single one namedKafkaListenerReconcilerTestas these tests use the same level of mocking etc.KafkaClusterCreatorTestalready contained a mix of ZooKeeper and KRaft-based tests. I kept the KRaft-based tests inKafkaClusterCreatorTestwith minor improvements only. The ZooKeeper-based tests were moved to a separate classKafkaClusterCreatorZooBasedTestto provide better separation and make it easier to just delete it in the future.Checklist