Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename private reconcile method to reconcileKafkaRebalance #10438

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Rename private reconcile method to reconcileKafkaRebalance #10438

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7646ee
Rename private `reconcile` method to `reconcileKafkaRebalance`
steffen-karlsson Aug 12, 2024
bb19e1c
Updating names to suggested
steffen-karlsson Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...in/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,9 @@ private KafkaRebalanceStatus updateStatus(KafkaRebalance kafkaRebalance,
return rebalanceOptionsBuilder;
}

private Future<KafkaRebalanceStatus> reconcile(Reconciliation reconciliation, String host,
CruiseControlApi apiClient, KafkaRebalance kafkaRebalance,
KafkaRebalanceState currentState) {
private Future<KafkaRebalanceStatus> reconcileKafkaRebalance(Reconciliation reconciliation, String host,
CruiseControlApi apiClient, KafkaRebalance kafkaRebalance,
KafkaRebalanceState currentState) {

if (kafkaRebalance != null && kafkaRebalance.getStatus() != null
&& "Ready".equals(rebalanceStateConditionType(kafkaRebalance.getStatus()))
Expand Down Expand Up @@ -1133,7 +1133,7 @@ private Future<MapAndStatus<ConfigMap, KafkaRebalanceStatus>> onReady(Reconcilia
}
currentState = KafkaRebalanceState.valueOf(rebalanceStateType);
}
return reconcile(reconciliation, cruiseControlHost(clusterName, clusterNamespace),
return reconcileKafkaRebalance(reconciliation, cruiseControlHost(clusterName, clusterNamespace),
apiClient, currentKafkaRebalance, currentState);
}, exception -> Future.failedFuture(exception));
});
Expand Down
Loading