Refactoring KafkaRebalance state extraction #10445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Patierno <ppatierno@live.com>
scholzj
approved these changes
Aug 14, 2024
yeah will do. Starting regression tests meanwhile :-) |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
The regression I started before adding unit testing is finally green. https://dev.azure.com/cncf/strimzi/_build/results?buildId=177859&view=results I think we can merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR does a little bit of refactoring around how the "state" of a rebalancing is extracted from the
KafkaRebalancestatus, avoiding using String for comparison and too many methods.Doing that, it provides a new
KafkaRebalanceUtilsclass where the main related methods are moved. This class could host more in a future refactoring.Also, it provides a way to access the rebalancing state for a
KafkaRebalanceeven in relation to the auto-rebalancing work.Checklist