Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed the token-permission and pinned dependencies issue #10463

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: fixed the token-permission and pinned dependencies issue #10463

merged 1 commit into from
Aug 19, 2024

Conversation

harshitasao
Copy link
Contributor

Type of change

Select the type of your PR

  • Bugfix

Description

fixed the token-permission and pinned dependencies issue reported by scorecard.

Part of #10457

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@harshitasao
fix: fixed the token-permission and pinned dependencies issue
616b1fc 
Signed-off-by: harshitasao <harshitasao@gmail.com>
@harshitasao harshitasao mentioned this pull request Aug 18, 2024
Open
4 tasks
scholzj
scholzj approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@scholzj scholzj added this to the 0.43.0 milestone Aug 18, 2024
@scholzj scholzj requested a review from a team August 18, 2024 13:15
see-quick
see-quick approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks.

@scholzj scholzj merged commit ce5d124 into strimzi:main Aug 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

@see-quick see-quick see-quick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.43.0
Development

Successfully merging this pull request may close these issues.
4 participants
@harshitasao @scholzj @ppatierno @see-quick